feat(gha)!: use composite action for semantic release (#692) by bernardcooke53 · Pull Request #741 · python-semantic-release/python-semantic-release · GitHub

No description provided.

@zckv I have moved the changes from #692 over here.

I'm thinking I want to add the following to this PR (based off of the breakage in the previous one):

Document additional requirements for workflows now that the action isn't Dockerized
- e.g. add a setup-python step
Add a workflow to test the GitHub action on runners using each of ubuntu-latest, macos-latest and windows-latest
- I've been playing about with some usage here which I think could be a starting point
The entrypoint action.sh will need to be re-worked to be cross-platform, because when I ran this on windows-latest it fell over quite quickly - the easiest thing will probably be to just make it a Python script instead of shell.

Will make PRs against this branch for each of those, obviously no obligation but if you still want to work on the change would you mind doing the same please? That way it can all be merged at once 🙏

Later versions reverted python-semantic-release/python-semantic-release#692 which breaks builds on Python projects requiring a newer interpreter than 3.10, which their container uses. Should be fine to update after python-semantic-release/python-semantic-release#741 is merged again. Signed-off-by: Felix Kaechele <felix@kaechele.ca>

Would really love to see this PR go through because without it, projects that use a newer Python than 3.10 can't use the action at all. Pinning to 8.3.0 for now as well.

Resolves: #692 Co-authored-by: Bernard Cooke <bernard-cooke@hotmail.com>

see python-semantic-release/python-semantic-release#741

Would really love to see this PR go through because without it, projects that use a newer Python than 3.10 can't use the action at all. Pinning to 8.3.0 for now as well.

@eikowagenknecht, although this composite action has not been merged yet. #914 has and it bumped the Docker action up to Python:3.12-bookworm as the base environment which will allow building of projects that use a minimum version of 3.11 & 3.12.

Hello 👋

Wouldn't it be simpler to create a separate action repository ? This solution would avoid a "breaking" change on this project for something that is not related to the PSR python code.

Wouldn't it be simpler to create a separate action repository ?

No, I don't believe so. It sounds nice up front but we would then have to keep both projects in sync. This action change would still be a breaking change which would then cause a version number drift of the version numbers of the project which likely confuses the configurations used and the users. This may not matter as the proper version is a set dependency in the action.

I plan to wrap it in with the next breaking change for the project. The release will have a full migration instructions and such with it. Maybe at the breaking change it's moved to another repository which doesn't change all that much besides the version it points to upon this repository update.

@eikowagenknecht, although this composite action has not been merged yet. #914 has and it bumped the Docker action up to Python:3.12-bookworm as the base environment which will allow building of projects that use a minimum version of 3.11 & 3.12.

Thanks, working fine for 3.12 now.