FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Improve private _nat_cmp() method by tomschr · Pull Request #445 · python-semver/python-semver · GitHub

/ python-semver Public

Improve private _nat_cmp() method - #445

Merged
tomschr merged 1 commit into
python-semver:masterfrom
tomschr:improve_nat_cmp
Oct 17, 2024
ConversationCommits (1)ChecksFiles changed
Merged

Improve private _nat_cmp() method#445
tomschr merged 1 commit into
python-semver:masterfrom
tomschr:improve_nat_cmp

Conversation

tomschr commented Oct 17, 2024

Copy link
Copy Markdown
Member
  • Remove obsolete else
  • Find a better way to identify digits without the re module
  • Fix docstring in compare

tomschr added the Enhancement Not a bug, but increases or improves in value, quality, desirability, or attractiveness label Oct 17, 2024
tomschr marked this pull request as ready for review October 17, 2024 11:40
Improve private _nat_cmp() method
0f30183 
* Remove obsolete else
* Find a better way to identify digits without the re module
* Fix docstring in compare
tomschr merged commit 8daa571 into python-semver:master Oct 17, 2024
tomschr deleted the improve_nat_cmp branch October 17, 2024 12:03
tomschr mentioned this pull request Dec 13, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Enhancement Not a bug, but increases or improves in value, quality, desirability, or attractiveness

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Back | FazBrowse Home | New Git URL