FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Improve PEP-compliance and testing by eigenein · Pull Request #56 · python-smpplib/python-smpplib · GitHub

/ python-smpplib Public

Improve PEP-compliance and testing - #56

Merged
eigenein merged 1 commit into
python-smpplib:masterfrom
eigenein:master
Oct 11, 2018
ConversationCommits (1)ChecksFiles changed
Merged

Improve PEP-compliance and testing#56
eigenein merged 1 commit into
python-smpplib:masterfrom
eigenein:master

Conversation

eigenein commented Oct 2, 2018 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  • Add tox.ini, support 2.6, 2.7, 3.4, 3.5, 3.6 and 3.7
  • Drop Python 3.2 and 3.3 support
  • Improve PEP8-compliance in a few places
  • Bump version to 1.0.2 and mark it as stable
  • Add classifiers to setup.py
  • Improve .gitignore with standard templates for popular environments
  • Remove some dead code in comments

eigenein commented Oct 11, 2018

Copy link
Copy Markdown
Collaborator Author

@podshumok Could you please take a quick look if it's okay for you?

code-of-kpp reviewed Oct 11, 2018
View reviewed changes
Comment thread smpplib/client.py Outdated
if sequence_generator is None:
sequence_generator = SimpleSequenceGenerator()
self.sequence_generator = sequence_generator
self.sequence_generator = sequence_generator or SimpleSequenceGenerator()

code-of-kpp Oct 11, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think is None version is better here as people may want to override __bool__ for things like sequence generators

eigenein Oct 11, 2018

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yeah, makes sense. I'll change it back.

code-of-kpp commented Oct 11, 2018

Copy link
Copy Markdown
Member

Some strings are too long for my screen (I have vision problems and hence I use PEP8 recommended 79 columns). Apart from that it looks good.

eigenein commented Oct 11, 2018

Copy link
Copy Markdown
Collaborator Author

Got it, will reformat those lines.

Improve PEP-compliance and testing
7fc36f2 
* Add `tox.ini`, support `2.6`, `2.7`, `3.4`, `3.5`, `3.6` and `3.7`
* Drop Python `3.2` and `3.3` support
* Improve PEP8-compliance in a few places
* Bump version to `1.0.2` and mark it as stable
* Add classifiers to `setup.py`
* Improve `.gitignore` with standard templates for popular environments
* Remove some dead code in comments

eigenein commented Oct 11, 2018

Copy link
Copy Markdown
Collaborator Author

Oki, addressed the comments.

eigenein merged commit 9850f8e into python-smpplib:master Oct 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

code-of-kpp code-of-kpp left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL