Fix UCS-2 encoding: fixes #49 and #53 - #59
Merged
eigenein merged 1 commit intoOct 15, 2018
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced Oct 15, 2018
eigenein
commented
Oct 15, 2018
Comment thread
smpplib/gsm.py
| # Split the text into well-formed parts. | ||
| esm_class = consts.SMPP_GSMFEAT_UDHI | ||
| # FIXME: 7-bit encoding has variable-length characters. | ||
| # FIXME: it means that a character may be broken by splitting. |
Copy link
Copy Markdown
Collaborator
Author
There was a problem hiding this comment.
Just had a thought that there's another issue too. We check len(text) but later we split encoded byte-string. It means that 2-byte characters are encountered as they were 1-octet characters.
Sorry, something went wrong.
Copy link
Copy Markdown
|
NIce |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should close #49 and #53.