| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
If you're up to, otherwise just merge it as is |
Sorry, something went wrong.
|
@eigenein Something like this ? |
Sorry, something went wrong.
There was a problem hiding this comment.
Yep, I think TypeError and ValueError is a good enough choice 👍
Sorry, something went wrong.
|
Please, add/update requirements for custom sequence generator to README as potentially breaking changes |
Sorry, something went wrong.
|
@podshumok I understand the part about adding information about it on the README but why are you mentionning breaking changes ? |
Sorry, something went wrong.
|
I take that back, I thought you create other implementation instance if it is passed |
Sorry, something went wrong.
|
confusing part is that start_sequence will not work with custom sequence generator |
Sorry, something went wrong.
|
So I think we don't need this argument in Client constructor. You can create SimpleSequenceGgenerator instance with desired start_sequence and pass this instance to the client's __init__ |
Sorry, something went wrong.
|
I'm okay with either option. One seems less DRY, another is more friendly |
Sorry, something went wrong.
|
I vote for SimpleSequenceGenerator, ask for some documentation and/or tests (but I don't insist), and vote against start_sequence in Client |
Sorry, something went wrong.
|
@podshumok @eigenein Made some changes, let me know if that's ok now. |
Sorry, something went wrong.
| import mymodule | ||
|
|
||
| generator = mymodule.PersistentSequenceGenerator() | ||
| generator = mymodule.MyAwesomeSequenceGenerator() |
There was a problem hiding this comment.
Please elaborate a little about the interface such a Generator has to have
Sorry, something went wrong.
There was a problem hiding this comment.
If you don't have time for this, also please let us know and @eigenein will merge it as is.
Sorry, something went wrong.
There was a problem hiding this comment.
@podshumok @eigenein Feel free to add this info to the readme if you wish, I don't think I will have time to.
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
That way anyone can easily implement a "persistent" generator without having to create a new class.
Feel free to comment whatever you think about it.
Should I add some checks to make sure it is a int that is in the valid range 0x00000000-0x7FFFFFFF ?