FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

V13 API 6.2 implementation by Poolitzer · Pull Request #3203 · python-telegram-bot/python-telegram-bot · GitHub

V13 API 6.2 implementation - #3203

Merged
Bibo-Joshi merged 7 commits into
v13.xfrom
v13-api6.2
Sep 4, 2022
Merged

V13 API 6.2 implementation#3203
Bibo-Joshi merged 7 commits into
v13.xfrom
v13-api6.2

Conversation

Copy link
Copy Markdown
Member

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Documented code changes according to the CSI standard
  • Added myself alphabetically to AUTHORS.rst (optional)
  • Added new classes & modules to the docs and all suitable __all__ s

If the PR contains API changes (otherwise, you can delete this passage)

  • New classes:

    • Added self._id_attrs and corresponding documentation
    • __init__ accepts **_kwargs
  • Added new shortcuts:

    • In Chat & User for all methods that accept chat/user_id
    • In Message for all methods that accept chat_id and message_id
    • For new Message shortcuts: Added quote argument if methods accepts reply_to_message_id
    • In CallbackQuery for all methods that accept either chat_id and message_id or inline_message_id
  • If relevant:

    • Added new constants at telegram.constants and shortcuts to them as class variables
    • Link new and existing constants in docstrings instead of hard coded number and strings
    • Add new message types to Message.effective_attachment
    • Added new handlers for new update types
      • Add the handlers to the warning loop in the ConversationHandler
    • Added new filters for new message (sub)types
    • Added or updated documentation for the changed class(es) and/or method(s)
    • Added or updated bot_methods.rst
    • Updated the Bot API version number in all places: README.rst and README_RAW.rst (including the badge), as well as telegram.constants.BOT_API_VERSION
    • Added logic for arbitrary callback data in tg.ext.Bot for new methods that either accept a reply_markup in some form or have a return type that is/contains telegram.Message

github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)

Bibo-Joshi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for the fast PR!

  • test_official is complaining that StickerSet.contains_masks is still present. Can you check how we handled such cases in the past?
  • DeepSource is complaining about two places where we could use f-strings. Feel free to improve, or just add a # skipcq: …

Comment thread telegram/bot.py Outdated
Comment thread telegram/bot.py
Comment thread telegram/bot.py Outdated
Comment thread telegram/chat.py
Comment thread telegram/files/sticker.py Outdated
Comment thread telegram/message.py
Comment thread telegram/message.py Outdated
Comment thread telegram/message.py Outdated
Comment thread telegram/message.py Outdated
Comment thread telegram/message.py Outdated
harshil21 added this to the v13.14 milestone Aug 26, 2022
harshil21 added the ⚙️ bot-api affected functionality: bot-api label Aug 26, 2022

Copy link
Copy Markdown
Member

Thanks for the updates. I think I'm happy with the changes, then. I vote to ignore DS on this for the reasons mentioned in https://discuss.deepsource.io/t/improve-granular-setting-possibility-to-pin-a-deepsource-version/472.

Bibo-Joshi merged commit dca596d into v13.x Sep 4, 2022
Bibo-Joshi deleted the v13-api6.2 branch September 4, 2022 07:15
github-actions Bot locked and limited conversation to collaborators Sep 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

⚙️ bot-api affected functionality: bot-api

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL