refactor: add enum constants - #3336
Closed
lemontree210 wants to merge 8 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
* add constants for `max_connections` * expand docstring for `secret_token`
* add limits for heading * add minimum proximity_alert_radius (as it is non-zero) * fix docstrings that link to HEADING constant twice instead of PROXIMITY_ALERT_RADIUS (and hence 360 was displayed instead of 100000)
harshil21
reviewed
Nov 5, 2022
Comment thread
telegram/constants.py
Outdated
Copy link
Copy Markdown
Member
Author
|
Question regarding limits for Location and send_location: I know that in Telegram API itself most limits are only listed in sendLocation and not in Location, e.g. live_period and heading. Should I list all the limits in Location as well or do I stick to what's listed or not listed in Telegram API? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
I think we should stick to TG API docs. |
Sorry, something went wrong.
Bibo-Joshi
reviewed
Nov 6, 2022
Comment thread
telegram/constants.py
8 tasks
Copy link
Copy Markdown
Member
Author
|
closing this PR, all work moved to #3351 (with branches within same repo as opposed to fork) |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses #3107