Add can_manage_topics for promoteChatMember and Chat* classes - #3342
Merged
Bibo-Joshi merged 7 commits intoNov 11, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Poolitzer
requested changes
Nov 6, 2022
Comment thread
telegram/_bot.py
Outdated
Comment thread
telegram/_chatadministratorrights.py
Outdated
Comment thread
telegram/_chatmember.py
Outdated
Comment thread
telegram/_chatmember.py
Outdated
Comment thread
telegram/_chatmember.py
Outdated
Comment thread
telegram/_chatpermissions.py
Outdated
Copy link
Copy Markdown
Member
Author
|
uh, why the precommit is failing, it says to format test_chat.py which I didnt even touched, also the precommit tests pass locally |
Sorry, something went wrong.
Bibo-Joshi
reviewed
Nov 9, 2022
Bibo-Joshi
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks good overall, just smaller comments :)
Sorry, something went wrong.
Bibo-Joshi
reviewed
Nov 9, 2022
Comment thread
telegram/_chatadministratorrights.py
harshil21
requested changes
Nov 11, 2022
harshil21
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Sorry for late review.
Found some tiny doc inconsistencies, along with a (unintentional?) breaking change.
Sorry, something went wrong.
Comment thread
telegram/_bot.py
Comment thread
telegram/_chatadministratorrights.py
Comment thread
telegram/_chatadministratorrights.py
Comment thread
telegram/_chatmember.py
Comment thread
telegram/_chatmember.py
Comment thread
telegram/_chatmember.py
Comment thread
telegram/_chatmember.py
Comment thread
telegram/_chatpermissions.py
Comment thread
telegram/_chatpermissions.py
Comment thread
tests/test_chatmember.py
Bibo-Joshi
added a commit
that referenced
this pull request
Nov 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adresses the first part of #3340