add message_thread_id param to methods, message_thread_id and is_topic_message to Message - #3345
Merged
Bibo-Joshi merged 8 commits intoNov 9, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
* haven't added this param to shortcuts yet * testing doesn't seem to be possible before ForumTopic class is implemented
Poolitzer
requested changes
Nov 6, 2022
Poolitzer
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks good!
Sorry, something went wrong.
Comment thread
telegram/_bot.py
Outdated
+ minor in Bot: delete one line break
…essage_thread_id_3340
Copy link
Copy Markdown
Member
Author
|
Hey guys, do you maybe think that we should merge this into api_6.3_update and then I'd branch off again when it becomes possible to add tests with real methods and attributes? |
Sorry, something went wrong.
lemontree210
marked this pull request as ready for review
November 8, 2022 10:47
Bibo-Joshi
approved these changes
Nov 9, 2022
Bibo-Joshi
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
One inquery, but the changes LGTM :) can be merged IMO
Sorry, something went wrong.
Comment thread
telegram/_message.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses #3340