Make answer_web_app_query insert/replace default values - #3364
Merged
Bibo-Joshi merged 3 commits intoNov 18, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
harshil21
approved these changes
Nov 14, 2022
harshil21
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
feels so ancient already
Sorry, something went wrong.
Copy link
Copy Markdown
There was a problem hiding this comment.
Hey! Looks like you edited the (dev) requirements or the pre-commit hooks. I'm just a friendly reminder to keep the pre-commit hook versions in sync with the dev requirements and the additional dependencies for the hooks in sync with the requirements :)
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I can't seem to get the CI running, it always fails in the coverage step. coverage seems to be okay though and I'm going to ignore the unrelated DS issue. Merging. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3358