Rate limit override - #5330
Conversation
Sorry, something went wrong.
| @@ -0,0 +1 @@ | |||
| bugfixes = "Respect an explicit rate_limit_args=0 in AIORateLimiter" | |||
There was a problem hiding this comment.
The file is missing a few more attributes, can you look at the other .tomls and update this?
Sorry, something went wrong.
There was a problem hiding this comment.
Done, updated the changelog entry and reverted the unrelated test change. Thanks!
Sorry, something went wrong.
There was a problem hiding this comment.
Can you also fix the failing prek action? Don't worry about the other failing tests
Sorry, something went wrong.
There was a problem hiding this comment.
Done, i fix it. Thanks!)
Sorry, something went wrong.
| assert all(task.done() for task in non_chat_tasks.values()) | ||
| assert all(task.done() for task in chat_tasks.values()) | ||
| finally: | ||
| # cleanup |
There was a problem hiding this comment.
please revert this
Sorry, something went wrong.
Reviewers
Requested changes must be addressed to merge this pull request.
Fix AIORateLimiter handling of rate_limit_args=0.
Previously, passing 0 could be treated as a falsy value and fall back to the configured default retry limit. This change distinguishes an explicitly provided 0 from None, allowing callers to intentionally disable retries for a specific request while preserving the global default behavior when no override is provided.
Includes regression tests covering both explicit 0 and fallback-to-default behavior.