FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Validate non-string UUID types by Letsch22 · Pull Request #174 · python-validators/validators · GitHub

  1. python-validators
  2. validators

Repository navigation

Validate non-string UUID types #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kvesteri merged 3 commits into from
Sep 3, 2020
Conversation 0 Commits 3 Checks 0 Files changed
Merged

Validate non-string UUID types #174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
77e6934
Validate invalid UUID types
Sep 1, 2020
bb87978
Check for UUID instances
Sep 1, 2020
065341e
Fix import sorting
Sep 1, 2020
File filter

Filter by extension

Filter by extension .py  (2) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
19 changes: 19 additions & 0 deletions tests/test_uuid.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
# -*- coding: utf-8 -*-
from uuid import UUID

import pytest

from validators import uuid, ValidationFailure
Expand All @@ -11,6 +13,13 @@ def test_returns_true_on_valid_mac_address(value):
assert uuid(value)


@pytest.mark.parametrize(('value',), [
(UUID('2bc1c94f-0deb-43e9-92a1-4775189ec9f8'),),
])
def test_returns_true_on_valid_uuid_object(value):
assert uuid(value)


@pytest.mark.parametrize(('value',), [
('2bc1c94f-deb-43e9-92a1-4775189ec9f8',),
('2bc1c94f-0deb-43e9-92a1-4775189ec9f',),
Expand All @@ -19,3 +28,13 @@ def test_returns_true_on_valid_mac_address(value):
])
def test_returns_failed_validation_on_invalid_mac_address(value):
assert isinstance(uuid(value), ValidationFailure)


@pytest.mark.parametrize(('value',), [
(1,),
(1.0,),
(True,),
(None,),
])
def test_returns_failed_validation_on_invalid_types(value):
assert isinstance(uuid(value), ValidationFailure)
12 changes: 10 additions & 2 deletions validators/uuid.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
from __future__ import absolute_import

import re
from uuid import UUID

from .utils import validator

Expand Down Expand Up @@ -28,6 +31,11 @@ def uuid(value):
.. versionadded:: 0.2
:param value: UUID string to validate
:param value: UUID value to validate
"""
return pattern.match(value)
if isinstance(value, UUID):
return True
try:
return pattern.match(value)
except TypeError:
return False
Back | FazBrowse Home | New Git URL