Repository navigation
fix: rfc cases in the domain validator - #367
Merged
nandgator merged 1 commit intoApr 19, 2024
Merged
nandgator merged 1 commit into
nandgator merged 1 commit into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
hagenrd
reviewed
Apr 18, 2024
Comment thread
src/validators/domain.py
Copy link
Copy Markdown
|
I left one small comment, but outside of that the issues described in #366 look to be resolved. Thanks! |
Sorry, something went wrong.
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Apr 26, 2024
https://build.opensuse.org/request/show/1170193 by user mia + anag+factory - Update to 0.28.1 * fix: reduce memory footprint when loading TLDs gh#python-validators/validators#362 * fix: rfc cases in the domain validator gh#python-validators/validators#367 * chore: documentation maintenance gh#python-validators/validators#368
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #366