Repository navigation
fix(ip_address): properly handle private is false - #374
Merged
nandgator merged 4 commits intoMay 17, 2024
Merged
nandgator merged 4 commits into
nandgator merged 4 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
nandgator
requested changes
May 11, 2024
VascoSch92
reviewed
May 12, 2024
Comment thread
tests/test_ip_address.py
Outdated
nandgator
requested changes
May 14, 2024
Comment thread
src/validators/ip_address.py
Outdated
Comment thread
tests/test_ip_address.py
Outdated
Comment thread
tests/test_ip_address.py
Outdated
Comment thread
tests/test_ip_address.py
Outdated
nandgator
approved these changes
May 17, 2024
nandgator
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Looks good. Thanks for the PR!
Sorry, something went wrong.
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
May 28, 2024
https://build.opensuse.org/request/show/1176833 by user mia + anag+factory - Update to 0.28.3 * ensure _tld.txt is in sdist and bdist gh#python-validators/validators#379 - Changes in 0.28.2: * fix: corrects a few typo gh#python-validators/validators#371 * fix(ip_address): properly handle private is false gh#python-validators/validators#374 * chore(url): allow symbols and pictographs in url gh#python-validators/validators#375
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #373