Repository navigation
fix(uri): replace lstrip("mailto:") with manual prefix removal - #418
Merged
nandgator merged 1 commit intoMar 29, 2025
Merged
nandgator merged 1 commit into
nandgator merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
max-moser
force-pushed
the
mm/fix-mailto-check
branch
from
9182503 to
dbd9946
Compare
March 18, 2025 19:30
Copy link
Copy Markdown
Contributor
|
@max-moser str.removeprefix was introduced in Python 3.9. Since the package currently supports Python >=3.8, your PR will introduce an incompatibility. |
Sorry, something went wrong.
This comment was marked as outdated.
max-moser
force-pushed
the
mm/fix-mailto-check
branch
from
dbd9946 to
35e6a69
Compare
March 19, 2025 21:57
Copy link
Copy Markdown
Contributor
Author
|
updated the PR to avoid incompatibility. |
Sorry, something went wrong.
* the use of `lstrip()` here was a bit too aggressive * `removeprefix()` is only available with python 3.9+
nandgator
force-pushed
the
mm/fix-mailto-check
branch
from
35e6a69 to
1dbbd0c
Compare
March 29, 2025 05:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The use of lstrip() here was a bit too aggressive.
For example:
In [1]: "mailto:maximilian.moser@tuwien.ac.at".lstrip("mailto:") Out[1]: 'ximilian.moser@tuwien.ac.at'But:
In [2]: "mailto:maximilian.moser@tuwien.ac.at".removeprefix("mailto:") Out[2]: 'maximilian.moser@tuwien.ac.at'