Repository navigation
fix(cron): accept day-of-week 7 as a valid Sunday alias - #470
Open
binggao1230 wants to merge 1 commit into
Open
binggao1230 wants to merge 1 commit into
binggao1230 wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Standard cron syntax allows weekday values 0–7, where both 0 and 7 mean Sunday (documented in crontab(5) and implemented by vixie-cron, cronie, fcron, and most Unix cron daemons). The validator was enforcing a max of 6, rejecting valid expressions like `* * * * 7`, `0 0 * * 0-7`, and `0 0 * * 0,7`. Change the weekday upper bound from 6 to 7 and add three test cases that were previously (incorrectly) rejected.
itzzdev09
reviewed
Sep 21, 2026
itzzdev09
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
This is correct per the Vixie-cron convention where day-of-week accepts 0–7 with both 0 and 7 meaning Sunday. I tested the branch: * * * * 7, 0-7 and 0,7 are accepted, while 8 and the reversed 7-0 are still rejected — all as expected.
One coordination note: this touches cron.py, which my open PR #482 also modifies (it rewrites _validate_cron_component to support stepped ranges like 1-5/2). The two are compatible — my range check accepts end == max_val, so 0-7 still validates once max is 7 — but they'll want a coordinated merge to avoid a conflict.
Sorry, something went wrong.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
validators.cron() rejects valid cron expressions that use 7 for the day-of-week field. 7 is a well-documented alias for Sunday (the same as 0), supported by all major cron implementations (vixie-cron, cronie, fcron, and crontab(5)).
Root cause
In src/validators/cron.py, the weekdays component is validated with max_val=6:
Fix
Change the upper bound from 6 to 7. DOW 8 continues to be rejected (the existing test for '0 12 * * 8' still passes).
Tests
Three new cases added to test_returns_true_on_valid_cron:
All 29 cron tests pass; the 17 pre-existing ETH address failures are unrelated.