Repository navigation
Accept file:// URLs per RFC 8089 - #483
Open
itzzdev09 wants to merge 1 commit into
Open
itzzdev09 wants to merge 1 commit into
itzzdev09 wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
url() rejected file:// URLs like file:///var/www because their authority (netloc) is empty or "localhost", neither of which _validate_netloc accepts as a hostname. RFC 8089 defines both an empty and a "localhost" authority as valid for a local file URL. A file URL with a non-local authority (file://example.com/path) still goes through the normal hostname check, unchanged.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #481.
url() rejected file:// URLs such as file:///var/www because their authority (netloc) is empty or "localhost", neither of which _validate_netloc accepts as a hostname. RFC 8089 defines both an empty and a "localhost" authority as valid for a local file URL, so this adds file to the accepted schemes and skips hostname validation for those two authorities specifically.
A file:// URL with a non-local authority (file://example.com/path) still goes through the normal hostname check, unchanged.