Repository navigation
Reject an underscore in the last domain label - #485
Open
SashaMIT wants to merge 1 commit into
Open
SashaMIT wants to merge 1 commit into
SashaMIT wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
The last label allowed "_" with or without rfc_2782, so foo.ba_r validated.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
domain("foo.ba_r") returned True, and domain("example.co_uk") did too. hostname("foo.ba_r") and email("a@foo.ba_r") did too.
An underscore is allowed in a service label when rfc_2782 is set. example_.com and _sip._tcp.example.com still need that flag, and they still pass with it. The last label allowed _ either way. example.com, xn----gtbspbbmkef.xn--p1ai, and a.co still pass.
Fixes #484.
Test plan