Remove escapes before command names - #127
Open
ferdnyc wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
In the early days of `virtualenvwrapper.sh`, some commands were prefixed with an escape character (e.g. `\grep -E -v ...`) as a way of attempting to defeat local aliases and other redefinitions. (See, e.g. commit c5433fe.) But, the `command` and `builtin` metacommands are better ways of achieving that, and all of the commands in question have since been prefixed with the appropriate metacommand, making the escapes unnecessary. `command \grep -E -v ...` is just silly.
carltongibson
approved these changes
May 6, 2026
carltongibson
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Yep, looks good. 👍
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Tick the box to add this pull request to the merge queue (same as @mergifyio queue).
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the early days of virtualenvwrapper.sh, some commands were prefixed with an escape character (e.g. \grep -E -v ...) as a way of attempting to defeat local aliases and other redefinitions. (See, e.g. commit c5433fe.)
But, the command and builtin metacommands are better ways of achieving that, and all of the commands in question have since been prefixed with the appropriate metacommand, making the escapes unnecessary. command \grep -E -v ... is just silly.