feat: speed up parsing NSEC records - #1169
Merged
bdraco merged 1 commit intoMay 3, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov ReportPatch coverage: 100.00% and no project coverage change. Additional details and impacted files @@ Coverage Diff @@
## master #1169 +/- ##
=======================================
Coverage 99.81% 99.81%
=======================================
Files 22 22
Lines 2667 2671 +4
Branches 464 464
=======================================
+ Hits 2662 2666 +4
Misses 3 3
Partials 2 2
☔ View full report in Codecov by Sentry. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark before
Parsing 100000 incoming messages took 3.846316208015196 seconds
Benchmark after
Parsing 100000 incoming messages took 2.7343544159957673 seconds
Almost a 39% improvement