| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## master #1574 +/- ##
=======================================
Coverage 99.76% 99.76%
=======================================
Files 33 33
Lines 3400 3400
Branches 461 461
=======================================
Hits 3392 3392
Misses 5 5
Partials 3 3 ☔ View full report in Codecov by Sentry.
|
Sorry, something went wrong.
CodSpeed Performance ReportMerging #1574 will not alter performanceComparing mgorny:cython-3.1 (b9e8a38) with master (f5c15e9) Summary✅ 6 untouched benchmarks |
Sorry, something went wrong.
|
Removed the other change, as apparently there is no way to satisfy both ruff and cython, and limited this to that one clear fix. |
Sorry, something went wrong.
Fix `AsyncListener._respond_query()` to use `DNSIncoming` type
for the `msg` argument, matching `handle_query_or_defer()`. This fixes
the following error with Cython 3.1.0rc1:
```
Error compiling Cython file:
------------------------------------------------------------
...
def _cancel_any_timers_for_addr(self, addr: _str) -> None:
"""Cancel any future truncated packet timers for the address."""
if addr in self._timers:
self._timers.pop(addr).cancel()
def _respond_query(
^
------------------------------------------------------------
src/zeroconf/_listener.py:225:4: Signature not compatible with previous declaration
Error compiling Cython file:
------------------------------------------------------------
...
object port,
object transport,
tuple v6_flow_scope
)
cpdef _respond_query(
^
------------------------------------------------------------
src/zeroconf/_listener.pxd:51:24: Previous declaration is here
```
|
Okay, so the other problem is that _dns.pxd declares DNSRecord.ttl as cython.float but it's float | int on the Python end. |
Sorry, something went wrong.
|
change to chore so it doesn't release. Will try to fix a few more and than do a fix one at the end |
Sorry, something went wrong.
|
Thanks! |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Fix the few build failures I've hit with Cython 3.1.0rc1. Unfortunately, I'm stuck at:
Error compiling Cython file: ------------------------------------------------------------ ... version: IPVersion = IPVersion.All, ) -> list[DNSAddress]: """Return matching DNSAddress from ServiceInfo.""" return self._dns_addresses(override_ttl, version) def _dns_addresses( ^ ------------------------------------------------------------ src/zeroconf/_services/info.py:586:4: Signature not compatible with previous declaration Error compiling Cython file: ------------------------------------------------------------ ... cpdef addresses_by_version(self, object version) cpdef ip_addresses_by_version(self, object version) @cython.locals(cacheable=cython.bint) cdef cython.list _dns_addresses(self, object override_ttls, object version) ^ ------------------------------------------------------------ src/zeroconf/_services/info.pxd:124:35: Previous declaration is hereand the like. I suspect it doesn't like override_ttls but can't figure out how to make it work.