FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(ci): drop cp39 from cibuildwheel matrix by bdraco · Pull Request #1691 · python-zeroconf/python-zeroconf · GitHub

fix(ci): drop cp39 from cibuildwheel matrix - #1691

Merged
bdraco merged 1 commit into
masterfrom
fix-drop-cp39-wheel-matrix
May 16, 2026
Merged

fix(ci): drop cp39 from cibuildwheel matrix#1691
bdraco merged 1 commit into
masterfrom
fix-drop-cp39-wheel-matrix

Conversation

bdraco commented May 16, 2026

Copy link
Copy Markdown
Member

Summary

After #1688 bumped requires-python to >=3.10, two cp39 matrix entries were left behind in the cibuildwheel matrix. cibuildwheel refused them with No build identifiers selected, the failure cancelled every other arch in the wheel job (no fail-fast: false on this matrix), and 0.149.0 reached PyPI as sdist + one stray cp314 wheel only — upload_pypi was skipped because build_wheels didn't complete.

Details

Failing job: Wheels for ubuntu-latest (musllinux) armv7l cp39

##[error]cibuildwheel: No build identifiers selected:
BuildSelector(build_config='cp39*',
              skip_config='cp36-* cp37-* pp36-* pp37-* pp38-* cp38-*',
              requires_python=<SpecifierSet('>=3.10')>,
              enable=frozenset())
##[error]Process completed with exit code 3.

This PR removes the two stale entries:

  • ubuntu-latest qemu=armv7l musl=musllinux pyver=cp39
  • ubuntu-latest qemu=armv7l musl="" pyver=cp39

The fix: prefix lets PSR cut 0.149.1, so the wheel matrix runs once more and upload_pypi publishes a full cross-arch wheel set to replace the sdist-only 0.149.0.

Test plan

  • Merge → confirm PSR releases 0.149.1.
  • Confirm every Wheels for … job completes successfully (no more cancelled arches).
  • Confirm 0.149.1 on PyPI has the full wheel set (manylinux + musllinux x86_64 / aarch64 / armv7l / riscv64, macOS, Windows).

Follow-up worth considering

Add strategy.fail-fast: false to the build_wheels matrix so a single arch failure no longer cancels the other ~30 jobs. Happy to do that in a separate PR if you want.

`pyproject.toml` is now `requires-python = ">=3.10"` after #1688,
so cibuildwheel refused the explicit `CIBW_BUILD=cp39*` matrix entries
with "No build identifiers selected". The cp39 job's failure cancelled
the rest of the wheel matrix (no `fail-fast: false` on the matrix), so
0.149.0 reached PyPI as sdist only. Removing the two stale cp39 entries
lets the next release publish a full wheel set.

codspeed-hq Bot commented May 16, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 6 untouched benchmarks


Comparing fix-drop-cp39-wheel-matrix (2ec4f46) with master (1031559)1

Footnotes

  1. No successful run was found on master (023dcde) during the generation of this report, so 1031559 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

codecov Bot commented May 16, 2026
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.76%. Comparing base (1031559) to head (2ec4f46).
⚠️ Report is 92 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1691   +/-   ##
=======================================
  Coverage   99.76%   99.76%           
=======================================
  Files          33       33           
  Lines        3410     3410           
  Branches      464      464           
=======================================
  Hits         3402     3402           
  Misses          5        5           
  Partials        3        3           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

bdraco merged commit 591288b into master May 16, 2026
34 of 35 checks passed
bdraco deleted the fix-drop-cp39-wheel-matrix branch May 16, 2026 22:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL