FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: widen loopback find timeout on macos by bdraco · Pull Request #1832 · python-zeroconf/python-zeroconf · GitHub

/ python-zeroconf Public

test: widen loopback find timeout on macos - #1832

Merged
bdraco merged 1 commit into
masterfrom
fix-macos-find-timeout
Aug 28, 2026
ConversationCommits (1)ChecksFiles changed
Merged

test: widen loopback find timeout on macos#1832
bdraco merged 1 commit into
masterfrom
fix-macos-find-timeout

Conversation

bdraco commented Aug 28, 2026

Copy link
Copy Markdown
Member

Summary

test_integration_with_subtype_and_listener failed twice recently, both times on macos runners (3.10 and 3.13), with the second find() returning (); the captured log shows the registrar's PTR response was sent and received, it just landed after the 75ms find() sleep had already cancelled the browser.

Details

  • find() is a fixed time.sleep(timeout), so the timeout is a hard budget for the whole query and response round trip; locally that round trip is 1 to 7ms for every test in the file, on GitHub's macos runners the process stalls for longer than 75ms often enough to lose the answer
  • macos now gets the same 300ms LOOPBACK_FIND_TIMEOUT PyPy already uses, other platforms keep 75ms; this adds about 1.8s to each macos job

Test plan

  • tests/services/test_types.py passes locally on macos with the new budget
  • measured the query to add_service latency for both find() phases of the plain and subtype tests, 1 to 7ms in every run, so the failures are runner stalls rather than a systematic slow path

bdraco marked this pull request as ready for review August 28, 2026 22:01
bdraco merged commit 9e732c5 into master Aug 28, 2026
31 checks passed

codspeed-hq Bot commented Aug 28, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 24 untouched benchmarks

Comparing fix-macos-find-timeout (62a3e4b) with master (77f8cf0)1

Footnotes

  1. No successful run was found on master (228902a) during the generation of this report, so 77f8cf0 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

bdraco deleted the fix-macos-find-timeout branch August 28, 2026 22:01

codecov Bot commented Aug 28, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.81%. Comparing base (77f8cf0) to head (62a3e4b).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1832   +/-   ##
=======================================
  Coverage   99.81%   99.81%           
=======================================
  Files          33       33           
  Lines        3839     3839           
  Branches      553      553           
=======================================
  Hits         3832     3832           
  Misses          5        5           
  Partials        2        2

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Back | FazBrowse Home | New Git URL