FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: delete tests and examples containing non-consented work by bdraco · Pull Request #1842 · python-zeroconf/python-zeroconf · GitHub

  1. python-zeroconf
  2. python-zeroconf

Repository navigation

chore: delete tests and examples containing non-consented work - #1842

Merged
bdraco merged 1 commit into
masterfrom
delete_nonconsented_tests_examples
Aug 29, 2026
ConversationCommits (1)ChecksFiles changed
Merged

chore: delete tests and examples containing non-consented work#1842
bdraco merged 1 commit into
masterfrom
delete_nonconsented_tests_examples

Conversation

bdraco commented Aug 29, 2026

Copy link
Copy Markdown
Member

Summary

Part of #1835; deletes test and example content from authors who declined relicensing consent.

Details

  • examples/self_test.py is deleted outright; it is the original pyzeroconf self test script moved out of the 2009 __main__ block, and examples are not shipped or run in CI
  • the tests/test_init.py module docstring is removed; the tests themselves are modern and stay
  • the remaining flagged example lines in registration.py and browser.py come out in the next PR, since deleting them alone leaves the examples unlintable

Test plan

  • full suite passes; examples are not part of the packaged sdist or wheel and are not executed in CI

bdraco marked this pull request as ready for review August 29, 2026 17:37

codecov Bot commented Aug 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.87%. Comparing base (6b2a040) to head (2bf7d5f).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1842   +/-   ##
=======================================
  Coverage   99.87%   99.87%           
=======================================
  Files          33       33           
  Lines        3883     3883           
  Branches      567      567           
=======================================
  Hits         3878     3878           
  Misses          3        3           
  Partials        2        2

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codspeed Bot commented Aug 29, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 24 untouched benchmarks

Comparing delete_nonconsented_tests_examples (2bf7d5f) with master (6b2a040)1

Footnotes

  1. No successful run was found on master (546c30b) during the generation of this report, so 6b2a040 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

bdraco merged commit 6b2a9f6 into master Aug 29, 2026
35 checks passed
bdraco deleted the delete_nonconsented_tests_examples branch August 29, 2026 17:40
bdraco mentioned this pull request Aug 29, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Back | FazBrowse Home | New Git URL