FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

revert: remove the legacy license banner from every module by bdraco · Pull Request #1860 · python-zeroconf/python-zeroconf · GitHub

  1. python-zeroconf
  2. python-zeroconf

Repository navigation

revert: remove the legacy license banner from every module - #1860

Merged
bdraco merged 1 commit into
masterfrom
remove_license_banner
Aug 29, 2026
ConversationCommits (1)ChecksFiles changed
Merged

revert: remove the legacy license banner from every module#1860
bdraco merged 1 commit into
masterfrom
remove_license_banner

Conversation

bdraco commented Aug 29, 2026

Copy link
Copy Markdown
Member

Summary

Removes the 21 line pyzeroconf era banner from all 36 modules for #1835: the v0.14-wmcbrine title line, the 2003/2014 copyright line for work no longer present in the tree, the original project description prose, and the FSF notice boilerplate. The follow up adds a short header stating the LGPL license and pointing at the COPYING file, so per file licensing stays explicit. The license itself does not change.

Test plan

  • full suite passes; the banner was the module docstring in every file and nothing imports it
  • with the banner gone the audits no longer need header exclusions; re-run to confirm below

github-actions Bot commented Aug 29, 2026

Copy link
Copy Markdown

Thanks for contributing! A quick note: this project is in the process of moving from LGPL-2.1 to Apache 2.0, see #1835.

By continuing with this pull request you are okay with your contribution, and your previous contributions to this repository, being offered under Apache 2.0.

If that does not work for you, no hard feelings; reply with the exact phrase I do not agree to the Apache 2.0 license or simply close this pull request, and nothing of yours will be included in the change.

bdraco marked this pull request as ready for review August 29, 2026 20:50
bdraco merged commit 997167c into master Aug 29, 2026
33 of 34 checks passed
bdraco deleted the remove_license_banner branch August 29, 2026 20:50

codecov Bot commented Aug 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.87%. Comparing base (e5d38b0) to head (28887d8).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1860   +/-   ##
=======================================
  Coverage   99.87%   99.87%           
=======================================
  Files          33       33           
  Lines        3882     3882           
  Branches      567      567           
=======================================
  Hits         3877     3877           
  Misses          3        3           
  Partials        2        2

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

bdraco mentioned this pull request Aug 29, 2026
Merged
2 tasks done

codspeed Bot commented Aug 29, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 24 untouched benchmarks

Comparing remove_license_banner (28887d8) with master (e5d38b0)

This was referenced Aug 29, 2026
Open
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Back | FazBrowse Home | New Git URL