Repository navigation
chore: adopt the zc fixture across the remaining simple tests - #1876
bdraco merged 1 commit into
Conversation
Sorry, something went wrong.
|
Thanks for contributing! A quick note: this project is in the process of moving from LGPL-2.1 to Apache 2.0, see #1835. By continuing with this pull request you are okay with your contribution, and your previous contributions to this repository, being offered under Apache 2.0. If that does not work for you, no hard feelings; reply with the exact phrase I do not agree to the Apache 2.0 license or simply close this pull request, and nothing of yours will be included in the change. |
Sorry, something went wrong.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## master #1876 +/- ##
=======================================
Coverage 99.87% 99.87%
=======================================
Files 33 33
Lines 3882 3882
Branches 567 567
=======================================
Hits 3877 3877
Misses 3 3
Partials 2 2 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
Summary
Third cleanup pass. Twenty six more tests across test_core, test_listener, test_updates and services/test_browser drop their hand rolled loopback Zeroconf construct and close boilerplate for the zc fixture. Conversion is scoped per function and only applies where the construct and close pair is the whole lifecycle; tests whose close is mid behavior stay as they are, and one test that patches the cache cleanup interval at construction time was restored to inline construction since the fixture builds the instance before a decorator patch takes effect.
The fixtures now depend on verify_threads_ended, pinning teardown order so the instance always closes before the thread leak check runs.
Test plan