FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: add an add_question_batch helper for the packet count tests by bdraco · Pull Request #1882 · python-zeroconf/python-zeroconf · GitHub

Repository navigation

chore: add an add_question_batch helper for the packet count tests - #1882

Merged
bdraco merged 1 commit into
masterfrom
question_batch_helper
Aug 29, 2026
Merged

bdraco merged 1 commit into
masterfrom
question_batch_helper

Conversation

bdraco commented Aug 29, 2026

Copy link
Copy Markdown
Member

Summary

Follow up to #1881. The build N questions loops in the packet count tests collapse into an add_question_batch helper in the tests package; the helper documents that the default stem must stay eight characters because the packet count assertions depend on the encoded name length, which is exactly the coupling that made #1881 subtle.

Test plan

  • full suite passes, lint clean

Copy link
Copy Markdown

Thanks for contributing! A quick note: this project is in the process of moving from LGPL-2.1 to Apache 2.0, see #1835.

By continuing with this pull request you are okay with your contribution, and your previous contributions to this repository, being offered under Apache 2.0.

If that does not work for you, no hard feelings; reply with the exact phrase I do not agree to the Apache 2.0 license or simply close this pull request, and nothing of yours will be included in the change.

bdraco force-pushed the replace_testname_stragglers branch from aaead8d to 3f26b5a Compare August 29, 2026 23:05
bdraco force-pushed the question_batch_helper branch from 307c268 to 0d81a97 Compare August 29, 2026 23:05

codecov Bot commented Aug 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.87%. Comparing base (f340716) to head (0bb2076).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1882      +/-   ##
==========================================
+ Coverage   99.79%   99.87%   +0.07%     
==========================================
  Files          33       33              
  Lines        3882     3882              
  Branches      567      567              
==========================================
+ Hits         3874     3877       +3     
+ Misses          4        3       -1     
+ Partials        4        2       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Base automatically changed from replace_testname_stragglers to master August 29, 2026 23:08
bdraco force-pushed the question_batch_helper branch from 0d81a97 to 0bb2076 Compare August 29, 2026 23:09

codspeed Bot commented Aug 29, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 24 untouched benchmarks


Comparing question_batch_helper (0bb2076) with master (6d061a4)1

Footnotes

  1. No successful run was found on master (f340716) during the generation of this report, so 6d061a4 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

bdraco marked this pull request as ready for review August 29, 2026 23:14
bdraco merged commit 77315dd into master Aug 29, 2026
34 of 35 checks passed
bdraco deleted the question_batch_helper branch August 29, 2026 23:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL