FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: name the txt repr inline limit by bdraco · Pull Request #1883 · python-zeroconf/python-zeroconf · GitHub

Repository navigation

chore: name the txt repr inline limit - #1883

Merged
bdraco merged 1 commit into
masterfrom
name_txt_repr_limit
Aug 29, 2026
Merged

bdraco merged 1 commit into
masterfrom
name_txt_repr_limit

Conversation

bdraco commented Aug 29, 2026

Copy link
Copy Markdown
Member

Summary

Tiny follow up to #1880 that just missed the merge: the 16 byte inline threshold in the DNSText repr becomes a named module constant with its rationale, per the review note that deriving the number from a named diagnostic limit is the maximum caution form.

Test plan

  • repr tests pass

Copy link
Copy Markdown

Thanks for contributing! A quick note: this project is in the process of moving from LGPL-2.1 to Apache 2.0, see #1835.

By continuing with this pull request you are okay with your contribution, and your previous contributions to this repository, being offered under Apache 2.0.

If that does not work for you, no hard feelings; reply with the exact phrase I do not agree to the Apache 2.0 license or simply close this pull request, and nothing of yours will be included in the change.

bdraco marked this pull request as ready for review August 29, 2026 23:43

codspeed Bot commented Aug 29, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 24 untouched benchmarks


Comparing name_txt_repr_limit (8c83b60) with master (77fb26e)

bdraco merged commit 474ed30 into master Aug 29, 2026
35 checks passed
bdraco deleted the name_txt_repr_limit branch August 29, 2026 23:45

codecov Bot commented Aug 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.87%. Comparing base (77fb26e) to head (8c83b60).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1883   +/-   ##
=======================================
  Coverage   99.87%   99.87%           
=======================================
  Files          33       33           
  Lines        3909     3910    +1     
  Branches      568      568           
=======================================
+ Hits         3904     3905    +1     
  Misses          3        3           
  Partials        2        2           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL