FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: add modification notices to headers and require affirmative consent for past contributions by bdraco · Pull Request #1885 · python-zeroconf/python-zeroconf · GitHub

Repository navigation

chore: add modification notices to headers and require affirmative consent for past contributions - #1885

Merged
bdraco merged 1 commit into
masterfrom
consent_and_notice_hardening
Aug 30, 2026
Merged

bdraco merged 1 commit into
masterfrom
consent_and_notice_hardening

Conversation

bdraco commented Aug 30, 2026

Copy link
Copy Markdown
Member

Summary

Two hardening items from outside legal review of the relicensing work.

LGPL 2.1 section 2 asks modified files to carry prominent modification notices; the short headers from #1861 now state the work is continuously modified with dates recorded in git history, alongside the existing license pointer.

The license notice workflow no longer treats continuing a pull request as consent covering previous contributions. The new contribution is offered under the incoming license as with any project, and consent for past work happens only through the explicit statement on #1835; the notice now says silence is never treated as consent for past work.

Test plan

  • suite passes; workflow yaml validates

Copy link
Copy Markdown

Thanks for contributing! A quick note: this project is in the process of moving from LGPL-2.1 to Apache 2.0, see #1835.

By continuing with this pull request you are okay with your contribution, and your previous contributions to this repository, being offered under Apache 2.0.

If that does not work for you, no hard feelings; reply with the exact phrase I do not agree to the Apache 2.0 license or simply close this pull request, and nothing of yours will be included in the change.

bdraco marked this pull request as ready for review August 30, 2026 00:06
bdraco merged commit 0e7c22a into master Aug 30, 2026
34 checks passed
bdraco deleted the consent_and_notice_hardening branch August 30, 2026 00:06

codspeed Bot commented Aug 30, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 24 untouched benchmarks


Comparing consent_and_notice_hardening (4d425de) with master (474ed30)

codecov Bot commented Aug 30, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.87%. Comparing base (474ed30) to head (4d425de).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1885   +/-   ##
=======================================
  Coverage   99.87%   99.87%           
=======================================
  Files          33       33           
  Lines        3910     3910           
  Branches      568      568           
=======================================
  Hits         3905     3905           
  Misses          3        3           
  Partials        2        2           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL