FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: rework the remaining echoes flagged by the seventh independent audit by bdraco · Pull Request #1890 · python-zeroconf/python-zeroconf · GitHub

  1. python-zeroconf
  2. python-zeroconf

Repository navigation

chore: rework the remaining echoes flagged by the seventh independent audit - #1890

Merged
bdraco merged 1 commit into
masterfrom
seventh_audit_residue
Aug 30, 2026
ConversationCommits (1)ChecksFiles changed
Merged

chore: rework the remaining echoes flagged by the seventh independent audit#1890
bdraco merged 1 commit into
masterfrom
seventh_audit_residue

Conversation

bdraco commented Aug 30, 2026

Copy link
Copy Markdown
Member

Summary

Follow-up to the seventh independent audit of the #1835 removal claims, which reproduced every number in the issue and surfaced three remaining echoes: the readme fork note quoting the 2009 project description phrase, the launch and close test family, and one docstring still scoring against removed text.

Details

  • The readme fork note quoted "Multicast DNS Service Discovery for Python", the 2009 Browser.py description sentence, beyond plain attribution. The note now attributes the fork without quoting it, and picks up a grammar fix.
  • The six test_launch_and_close_* functions kept the 2009 test family's naming stem, and the unicast variant kept the 2009 body shape with a flag added. They fold into parametrized tests with fresh names: test_open_and_close_cleanly gains a unicast axis, the context manager test is parametrized over interfaces, the two IPv6 warning tests merge into one parametrized function, and the rv locals are renamed.
  • RecordManager's class docstring measured 0.67 against a removed 2009 descended line; reworded.

Test plan

  • full compiled test suite after REQUIRE_CYTHON=1 rebuild: 518 passed
  • pre-commit clean

github-actions Bot commented Aug 30, 2026

Copy link
Copy Markdown

Thanks for contributing! A quick note: this project is in the process of moving from LGPL-2.1 to Apache 2.0, see #1835.

By continuing with this pull request you agree that this new contribution is offered under Apache 2.0.

This notice does not affect your previous contributions. If you would like to consent to relicensing those as well, please post the consent statement on #1835; silence is never treated as consent for past work.

If offering this contribution under Apache 2.0 does not work for you, no hard feelings; reply with the exact phrase I do not agree to the Apache 2.0 license or simply close this pull request.

bdraco mentioned this pull request Aug 30, 2026
Open

codspeed Bot commented Aug 30, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 24 untouched benchmarks

Comparing seventh_audit_residue (a476aa3) with master (7737108)

codecov Bot commented Aug 30, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.87%. Comparing base (7737108) to head (a476aa3).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1890   +/-   ##
=======================================
  Coverage   99.87%   99.87%           
=======================================
  Files          33       33           
  Lines        3911     3911           
  Branches      568      568           
=======================================
  Hits         3906     3906           
  Misses          3        3           
  Partials        2        2

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

bdraco marked this pull request as ready for review August 30, 2026 01:42
bdraco merged commit cc92a76 into master Aug 30, 2026
40 of 41 checks passed
bdraco deleted the seventh_audit_residue branch August 30, 2026 01:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Back | FazBrowse Home | New Git URL