FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: drop the equality docstring family and reword the cache lookup docstring by bdraco · Pull Request #1892 · python-zeroconf/python-zeroconf · GitHub

  1. python-zeroconf
  2. python-zeroconf

Repository navigation

chore: drop the equality docstring family and reword the cache lookup docstring - #1892

Merged
bdraco merged 1 commit into
masterfrom
ninth_audit_residue
Aug 30, 2026
ConversationCommits (1)ChecksFiles changed
Merged

chore: drop the equality docstring family and reword the cache lookup docstring#1892
bdraco merged 1 commit into
masterfrom
ninth_audit_residue

Conversation

bdraco commented Aug 30, 2026

Copy link
Copy Markdown
Member

Summary

Follow-up to the ninth independent audit of the #1835 removal claims: it caught one undisclosed 2009 echo (DNSCache.get_all_by_details's docstring, 0.77 against the 2009 "Gets an entry by details.") and confirmed the equality docstrings still measure 0.60 to 0.69 against 2009 text despite an earlier claim they were reworded.

Details

  • The get_all_by_details docstring was written in 2021 as a variant of the 2009 line; it now describes the lookup in fresh words.
  • The eight """Equal when ... match.""" docstrings in _dns.py are deleted rather than reworded: an __eq__ docstring that names the compared fields restates the method body, the repo convention prefers no docstring in that case, and deletion removes the measured similarity for the whole family at once.

Test plan

  • full compiled test suite after REQUIRE_CYTHON=1 rebuild: 518 passed
  • pre-commit clean

bdraco marked this pull request as ready for review August 30, 2026 02:41
bdraco mentioned this pull request Aug 30, 2026
Open

codecov Bot commented Aug 30, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.87%. Comparing base (25f564a) to head (a8457d4).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1892   +/-   ##
=======================================
  Coverage   99.87%   99.87%           
=======================================
  Files          33       33           
  Lines        3911     3911           
  Branches      568      568           
=======================================
  Hits         3906     3906           
  Misses          3        3           
  Partials        2        2

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codspeed Bot commented Aug 30, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 24 untouched benchmarks

Comparing ninth_audit_residue (a8457d4) with master (25f564a)

github-actions Bot commented Aug 30, 2026

Copy link
Copy Markdown

Thanks for contributing! A quick note: this project is in the process of moving from LGPL-2.1 to Apache 2.0, see #1835.

By continuing with this pull request you agree that this new contribution is offered under Apache 2.0.

This notice does not affect your previous contributions. If you would like to consent to relicensing those as well, please post the consent statement on #1835; silence is never treated as consent for past work.

If offering this contribution under Apache 2.0 does not work for you, no hard feelings; reply with the exact phrase I do not agree to the Apache 2.0 license or simply close this pull request.

bdraco merged commit d5f4102 into master Aug 30, 2026
37 checks passed
bdraco deleted the ninth_audit_residue branch August 30, 2026 02:42
This was referenced Aug 30, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Back | FazBrowse Home | New Git URL