FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: correct the recursion available header flag to the rfc 1035 value by bdraco · Pull Request #1893 · python-zeroconf/python-zeroconf · GitHub

  1. python-zeroconf
  2. python-zeroconf

Repository navigation

fix: correct the recursion available header flag to the rfc 1035 value - #1893

Merged
bdraco merged 1 commit into
masterfrom
fix_ra_flag
Aug 30, 2026
ConversationCommits (1)ChecksFiles changed
Merged

fix: correct the recursion available header flag to the rfc 1035 value#1893
bdraco merged 1 commit into
masterfrom
fix_ra_flag

Conversation

bdraco commented Aug 30, 2026

Copy link
Copy Markdown
Member

Summary

_FLAGS_RA has been 0x8000 since 2009, which is the QR bit. RFC 1035 section 4.1.1 puts Recursion Available at bit 7, 0x0080.

Details

  • The constant is defined and never used (mDNS ignores RA per RFC 6762 section 18.6), so no packet ever carried the wrong value; this only matters if the constant is ever imported or used.
  • Every other flag in the block matches RFC 1035 section 4.1.1.

Test plan

  • full test suite: 518 passed
  • pre-commit clean

github-actions Bot commented Aug 30, 2026

Copy link
Copy Markdown

Thanks for contributing! A quick note: this project is in the process of moving from LGPL-2.1 to Apache 2.0, see #1835.

By continuing with this pull request you agree that this new contribution is offered under Apache 2.0.

This notice does not affect your previous contributions. If you would like to consent to relicensing those as well, please post the consent statement on #1835; silence is never treated as consent for past work.

If offering this contribution under Apache 2.0 does not work for you, no hard feelings; reply with the exact phrase I do not agree to the Apache 2.0 license or simply close this pull request.

bdraco marked this pull request as ready for review August 30, 2026 03:09

codspeed Bot commented Aug 30, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 8.19%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 23 untouched benchmarks

Performance Changes

Benchmark BASE HEAD Efficiency
⚡ test_sending_packets 112.7 µs 104.1 µs +8.19%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.

Comparing fix_ra_flag (e1377d1) with master (d5f4102)

codecov Bot commented Aug 30, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.87%. Comparing base (d5f4102) to head (e1377d1).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1893   +/-   ##
=======================================
  Coverage   99.87%   99.87%           
=======================================
  Files          33       33           
  Lines        3911     3911           
  Branches      568      568           
=======================================
  Hits         3906     3906           
  Misses          3        3           
  Partials        2        2

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

bdraco mentioned this pull request Aug 30, 2026
Open
bdraco merged commit 07e3812 into master Aug 30, 2026
41 checks passed
bdraco deleted the fix_ra_flag branch August 30, 2026 03:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Back | FazBrowse Home | New Git URL