FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: regenerate the incoming field order and retire remaining 2009 fingerprints by bdraco · Pull Request #1894 · python-zeroconf/python-zeroconf · GitHub

  1. python-zeroconf
  2. python-zeroconf

Repository navigation

chore: regenerate the incoming field order and retire remaining 2009 fingerprints - #1894

Merged
bdraco merged 1 commit into
masterfrom
tenth_audit_residue
Aug 30, 2026
ConversationCommits (1)ChecksFiles changed
Merged

chore: regenerate the incoming field order and retire remaining 2009 fingerprints#1894
bdraco merged 1 commit into
masterfrom
tenth_audit_residue

Conversation

bdraco commented Aug 30, 2026

Copy link
Copy Markdown
Member

Summary

Follow-up to the tenth independent audit of the #1835 removal claims: retires the remaining 2009 fingerprints it flagged outside the probe and request loops.

Details

  • DNSIncoming.__init__ still initialized its shared fields in the 2009 sequence; the assignments are regenerated under the same rule as DNSOutgoing in chore: rework the remaining shapes flagged by the sixth independent audit #1889 (public fields alphabetical, then private fields alphabetical). Assignment order is behavior neutral and the .pxd owns the struct layout.
  • The entry_to_string and to_string compatibility shims kept the 2009 parameter names and the append-then-format shape. The optional data payload now lives in _format_display itself, both shims collapse to single delegating lines, and the parameters are renamed.
  • The TTL test double in test_browser.py matched the 2009 line byte for byte including its parentheses; it now matches the production formula instead.
  • pyproject.toml still allow-listed _GLOBAL_DONE, a 2009 global that no longer exists in the tree.

Test plan

  • full compiled test suite after REQUIRE_CYTHON=1 rebuild: 518 passed
  • pre-commit clean

bdraco mentioned this pull request Aug 30, 2026
Open
bdraco marked this pull request as ready for review August 30, 2026 03:16

github-actions Bot commented Aug 30, 2026

Copy link
Copy Markdown

Thanks for contributing! A quick note: this project is in the process of moving from LGPL-2.1 to Apache 2.0, see #1835.

By continuing with this pull request you agree that this new contribution is offered under Apache 2.0.

This notice does not affect your previous contributions. If you would like to consent to relicensing those as well, please post the consent statement on #1835; silence is never treated as consent for past work.

If offering this contribution under Apache 2.0 does not work for you, no hard feelings; reply with the exact phrase I do not agree to the Apache 2.0 license or simply close this pull request.

codspeed Bot commented Aug 30, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 8.33%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 23 untouched benchmarks

Performance Changes

Benchmark BASE HEAD Efficiency
⚡ test_sending_packets 112.7 µs 104 µs +8.33%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.

Comparing tenth_audit_residue (e75425e) with master (d5f4102)

codecov Bot commented Aug 30, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.87%. Comparing base (d5f4102) to head (e75425e).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1894      +/-   ##
==========================================
- Coverage   99.87%   99.87%   -0.01%     
==========================================
  Files          33       33              
  Lines        3911     3910       -1     
  Branches      568      568              
==========================================
- Hits         3906     3905       -1     
  Misses          3        3              
  Partials        2        2

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

bdraco merged commit b110640 into master Aug 30, 2026
37 checks passed
bdraco deleted the tenth_audit_residue branch August 30, 2026 03:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Back | FazBrowse Home | New Git URL