FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: ignore compiled extensions and cython annotate output by bdraco · Pull Request #1898 · python-zeroconf/python-zeroconf · GitHub

  1. python-zeroconf
  2. python-zeroconf

Repository navigation

chore: ignore compiled extensions and cython annotate output - #1898

Merged
bdraco merged 1 commit into
masterfrom
ignore_build_artifacts
Aug 30, 2026
ConversationCommits (1)ChecksFiles changed
Merged

chore: ignore compiled extensions and cython annotate output#1898
bdraco merged 1 commit into
masterfrom
ignore_build_artifacts

Conversation

bdraco commented Aug 30, 2026

Copy link
Copy Markdown
Member

Summary

The fourteenth independent audit of the #1835 removal claims noted that the in-place compiled .so files under src/zeroconf/ were untracked but not ignored, so a stray git add -A could commit binaries (which embed docstrings from whatever source they were built against). The generated .c files were already ignored; this adds the .so and cython -a annotate .html outputs beside them.

Test plan

  • git status no longer lists the 18 compiled extensions

github-actions Bot commented Aug 30, 2026

Copy link
Copy Markdown

Thanks for contributing! A quick note: this project is in the process of moving from LGPL-2.1 to Apache 2.0, see #1835.

By continuing with this pull request you agree that this new contribution is offered under Apache 2.0.

This notice does not affect your previous contributions. If you would like to consent to relicensing those as well, please post the consent statement on #1835; silence is never treated as consent for past work.

If offering this contribution under Apache 2.0 does not work for you, no hard feelings; reply with the exact phrase I do not agree to the Apache 2.0 license or simply close this pull request.

bdraco mentioned this pull request Aug 30, 2026
Open
bdraco marked this pull request as ready for review August 30, 2026 05:23
bdraco merged commit 1cbeaf7 into master Aug 30, 2026
34 checks passed
bdraco deleted the ignore_build_artifacts branch August 30, 2026 05:23

codecov Bot commented Aug 30, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.87%. Comparing base (716f8d7) to head (7ce19e1).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1898   +/-   ##
=======================================
  Coverage   99.87%   99.87%           
=======================================
  Files          33       33           
  Lines        3911     3911           
  Branches      568      568           
=======================================
  Hits         3906     3906           
  Misses          3        3           
  Partials        2        2

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codspeed Bot commented Aug 30, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 24 untouched benchmarks

Comparing ignore_build_artifacts (7ce19e1) with master (716f8d7)

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Back | FazBrowse Home | New Git URL