| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Can you provide a test? |
Sorry, something went wrong.
|
Bugfix: Flush outdated cache entries when incoming record is unique. According to RFC 6762 10.2. Announcements to Flush Outdated Cache Entries, when the incoming record's cache-flush bit is set (record.unique == True in this module), "Instead of merging this new record additively into the cache in addition to any previous records with the same name, rrtype, and rrclass, all old records with that name, rrtype, and rrclass that were received more than one second ago are declared invalid, and marked to expire from the cache in one second." |
Sorry, something went wrong.
|
Tests have been added. |
Sorry, something went wrong.
|
Cheers. Are those actually two separate bugs you're fixing here? |
Sorry, something went wrong.
|
Yes, one for TXT record update for ServiceBrowser handler or listener, the other one is for support of record's cache-flush bit. |
Sorry, something went wrong.
|
Hi @jstasiak , anything else I should do to get these fixes merged? |
Sorry, something went wrong.
|
Hi, yes, the CI for the branch is not finishing successfully and that's required for merging – could you fix the build? |
Sorry, something went wrong.
|
BTW I'll move the tests to the relevant two commits when merging if you don't mind (you can do it yourself if you prefer that) – I'd like the commits to be self-contained. |
Sorry, something went wrong.
I don't know much about Travis CI, and the Details link says ""
I'd like to do it myself. I treat this as a Learn-by-Doing opportunity :-) |
Sorry, something went wrong.
Sure, please allow me some time. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
TXT record's name is never equal to Service Browser's type. We should check whether TXT record's name ends with Service Browser's type. Otherwise, we never get updates of TXT records.