FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Bugfix: TXT record's name is never equal to Service Browser's type. by humingchun · Pull Request #203 · python-zeroconf/python-zeroconf · GitHub

Repository navigation

Bugfix: TXT record's name is never equal to Service Browser's type. - #203

Closed
humingchun wants to merge 0 commit into
python-zeroconf:masterfrom
humingchun:master
Closed

humingchun wants to merge 0 commit into
python-zeroconf:masterfrom
humingchun:master

Conversation

Copy link
Copy Markdown

TXT record's name is never equal to Service Browser's type. We should check whether TXT record's name ends with Service Browser's type. Otherwise, we never get updates of TXT records.

jstasiak commented Nov 26, 2019 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Can you provide a test?

Copy link
Copy Markdown
Author

Bugfix: Flush outdated cache entries when incoming record is unique. According to RFC 6762 10.2. Announcements to Flush Outdated Cache Entries, when the incoming record's cache-flush bit is set (record.unique == True in this module), "Instead of merging this new record additively into the cache in addition to any previous records with the same name, rrtype, and rrclass, all old records with that name, rrtype, and rrclass that were received more than one second ago are declared invalid, and marked to expire from the cache in one second."

Copy link
Copy Markdown
Author

Tests have been added.

Copy link
Copy Markdown
Collaborator

Cheers. Are those actually two separate bugs you're fixing here?

Copy link
Copy Markdown
Author

Yes, one for TXT record update for ServiceBrowser handler or listener, the other one is for support of record's cache-flush bit.

Copy link
Copy Markdown
Author

Hi @jstasiak , anything else I should do to get these fixes merged?

jstasiak commented Dec 3, 2019

Copy link
Copy Markdown
Collaborator

Hi, yes, the CI for the branch is not finishing successfully and that's required for merging – could you fix the build?

jstasiak commented Dec 3, 2019

Copy link
Copy Markdown
Collaborator

BTW I'll move the tests to the relevant two commits when merging if you don't mind (you can do it yourself if you prefer that) – I'd like the commits to be self-contained.

Copy link
Copy Markdown
Author

Hi, yes, the CI for the branch is not finishing successfully and that's required for merging – could you fix the build?

I don't know much about Travis CI, and the Details link says ""

BTW I'll move the tests to the relevant two commits when merging if you don't mind (you can do it yourself if you prefer that) – I'd like the commits to be self-contained.

I'd like to do it myself. I treat this as a Learn-by-Doing opportunity :-)

Copy link
Copy Markdown
Author

Hi, yes, the CI for the branch is not finishing successfully and that's required for merging – could you fix the build?

Sure, please allow me some time.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL