FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Enable pylint by bdraco · Pull Request #438 · python-zeroconf/python-zeroconf · GitHub

Enable pylint - #438

Merged
bdraco merged 1 commit into
python-zeroconf:masterfrom
bdraco:enable_pylint
Jun 6, 2021
Merged

Enable pylint#438
bdraco merged 1 commit into
python-zeroconf:masterfrom
bdraco:enable_pylint

Conversation

bdraco commented Jun 5, 2021
edited
Loading

Copy link
Copy Markdown
Member
  • Disable dupe code check since asyncio will always have some dupes

  • Add pylint to requirements

bdraco force-pushed the enable_pylint branch 2 times, most recently from 22beb15 to 4515638 Compare June 5, 2021 20:56

bdraco commented Jun 5, 2021

Copy link
Copy Markdown
Member Author

zeroconf/__init__.py:1982:12: R1704: Redefining argument with the local name 'record' (redefined-argument-from-local)

That looks concerning

Need to see if its an actual bug

bdraco force-pushed the enable_pylint branch 2 times, most recently from 4f04057 to 39a88fb Compare June 5, 2021 21:38

bdraco commented Jun 5, 2021

Copy link
Copy Markdown
Member Author

Almost there

zeroconf/__init__.py:555:4: R0201: Method could be a function (no-self-use)
zeroconf/__init__.py:911:0: R0904: Too many public methods (22/20) (too-many-public-methods)
zeroconf/__init__.py:1789:17: W0212: Access to a protected member _handlers_lock of a client class (protected-access)
zeroconf/__init__.py:2298:0: R0912: Too many branches (14/12) (too-many-branches)
zeroconf/__init__.py:2380:23: E1101: Module 'errno' has no 'WSAEINVAL' member (no-member)
zeroconf/__init__.py:2769:4: R0201: Method could be a function (no-self-use)
zeroconf/__init__.py:2776:4: R0201: Method could be a function (no-self-use)
zeroconf/__init__.py:3041:28: E1101: Instance of 'Exception' has no 'errno' member (no-member)
zeroconf/__init__.py:2576:0: R0904: Too many public methods (25/20) (too-many-public-methods)

bdraco force-pushed the enable_pylint branch 2 times, most recently from 1f41fa6 to 2f961fa Compare June 5, 2021 23:22

bdraco commented Jun 5, 2021

Copy link
Copy Markdown
Member Author

Only thing left is zeroconf/__init__.py:3043:28: E1101: Instance of 'Exception' has no 'errno' member (no-member)

bdraco marked this pull request as ready for review June 5, 2021 23:44
- Disable dupe code check since asyncio will always have some dupes

- Add pylint to requirements

codecov-commenter commented Jun 5, 2021
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #438 (15f08c0) into master (9510808) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #438      +/-   ##
==========================================
- Coverage   95.46%   95.43%   -0.04%     
==========================================
  Files           4        4              
  Lines        3261     3261              
  Branches      406      406              
==========================================
- Hits         3113     3112       -1     
  Misses         89       89              
- Partials       59       60       +1     
Impacted Files Coverage Δ
zeroconf/asyncio.py 98.67% <100.00%> (-0.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9510808...15f08c0. Read the comment docs.

bdraco merged commit 6fafdee into python-zeroconf:master Jun 6, 2021
bdraco deleted the enable_pylint branch June 6, 2021 00:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL