Add blacken-target-version, remove blacken-allow-py36 - #47
Merged
CeleritasCelery merged 2 commits intoJan 10, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks for the PR! We will need to keep blacken-allow-py36 For compatibility, even if it is marked as deprecated. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Emacs has a facility to mark a variable as deprecated (obsolete). Let's use that for blacken-allow-py36. https://www.gnu.org/software/emacs/manual/html_node/elisp/Variable-Aliases.html |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I think having something like blacken-target-version instead of a py36 special case would be more preferable.
I can make the blacken-allow-py36 a deprecated special case if you want to, or I can have it simply deleted. Let me know which way you prefer