Update : Command for python 3 added by Shivang-Bhandari · Pull Request #73 · pythonindia/inpycon2017 · GitHub

Updated the command to run the project locally using Python 3

@akshayaurora would be great if you could take a look.

@Shivang-Bhandari please specify the python version you are using.
I deployed your fix and running staticjinja on Python 3.5.2 (other versions might also) is throwing error while importing easywatch which is a currently an open issue with a temporary solution.
It's better to go with the solution which works i.e. Python 2 in this case.

@realslimshanky Python 3.6.0
If you feel we should stick to Python 2 then it's not a problem.

@Shivang-Bhandari If you have tested it on 3.6.0 specifically do mention in the README about it. Because other versions might fail to run the script.

@realslimshanky sure

This should work for all versions > 3.3

Its better to mention that, 3.6 was released recently, but this should work with relatively newer python 3 versions

@SanketDG in the above comments @realslimshanky said it was not working for him for version 3.5.2, it would be great if you could update me and I can make the necessary changes. :)

Sorry for the late response, but the above code should work for any versions > 3.3 since there have been no breaking changes after that.

So you can go ahead and change that

@SanketDG Done

Would be great if you could merge it
:)

@SanketDG would you like to have another look after the update?

@realslimshanky LGTM

Update : Command for python 3 added

0cacd7b

Update README.md

c8fa127

SanketDG reviewed Jul 25, 2017

View reviewed changes

Update README.md

35841a2

+              For Python 3.6.0 :
+              ```
+              python build.py & python -m http.server && fg

Update : Command for python 3 added by Shivang-Bhandari · Pull Request #73 · pythonindia/inpycon2017 · GitHub

Repository navigation

Update : Command for python 3 added - #73

Update : Command for python 3 added#73Shivang-Bhandari wants to merge 3 commits intopythonindia:masterpythonindia/inpycon2017:masterfrom Shivang-Bhandari:masterShivang-Bhandari/inpycon2017:masterCopy head branch name to clipboard

Conversation

Shivang-Bhandari commented Jul 21, 2017

Uh oh!

Shivang-Bhandari commented Jul 21, 2017

Uh oh!

realslimshanky commented Jul 21, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Shivang-Bhandari commented Jul 22, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

realslimshanky commented Jul 23, 2017

Uh oh!

Shivang-Bhandari commented Jul 24, 2017

Uh oh!

SanketDG Jul 25, 2017

Choose a reason for hiding this comment

Uh oh!

Shivang-Bhandari Jul 27, 2017

Choose a reason for hiding this comment

Uh oh!

SanketDG Jul 31, 2017

Choose a reason for hiding this comment

Uh oh!

Shivang-Bhandari Aug 4, 2017

Choose a reason for hiding this comment

Uh oh!

Shivang-Bhandari Aug 4, 2017

Choose a reason for hiding this comment

Uh oh!

realslimshanky commented Oct 20, 2017

Uh oh!

SanketDG commented Oct 20, 2017

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Update : Command for python 3 added#73
Shivang-Bhandari wants to merge 3 commits into
pythonindia:masterfrom
Shivang-Bhandari:master

realslimshanky commented Jul 21, 2017 •
edited
Loading

Shivang-Bhandari commented Jul 22, 2017 •
edited
Loading