FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: stabilize tar extraction and iOS lifecycle tests by owenthcarey · Pull Request #110 · pythonnative/pythonnative · GitHub

test: stabilize tar extraction and iOS lifecycle tests - #110

Merged
owenthcarey merged 1 commit into
mainfrom
test/ci-stability
Oct 2, 2026
Merged

owenthcarey merged 1 commit into
mainfrom
test/ci-stability

Conversation

Copy link
Copy Markdown
Contributor

What

Why

  • build (3.14): CI picked up CPython 3.14.8, whose tarfile data filter now resolves a member that traverses a just-extracted symlink inside the destination instead of raising OutsideDestinationError. I reproduced it locally: nothing is written outside the destination, so the extraction is still safe; the test was pinned to the old way of enforcing it.
  • native-ios: testNativeHeaderSlotsAndModalPresentationKeepScreenOwnership asserted a modal's dismissal after a fixed 0.6 s delay, which a loaded CI simulator can outlast.

How (brief)

  • The tar test accepts either outcome and asserts containment: nothing lands outside the destination.
  • The iOS test waits for the modal's presentation and dismissal end states with a predicate expectation instead of a fixed delay.

Testing

  • tests/project/test_runtime_assets.py passes on CPython 3.13, 3.14.5, and 3.14.8.
  • PNLifecycleTests passes on an iPhone 17 Pro simulator (iOS 26.2).

Risks/Impact

  • Test-only changes.

CPython 3.14.8's tarfile data filter resolves a member that traverses a just-extracted symlink inside the destination instead of raising OutsideDestinationError. Both outcomes keep files inside the destination, which is what the test now asserts.

The iOS lifecycle test now waits for a modal's presentation and dismissal to finish instead of a fixed delay, which a loaded CI simulator can outlast.
owenthcarey changed the title test: accept CPython 3.14.8 tar filtering and wait on UIKit transitions test: stabilize tar extraction and iOS lifecycle tests Oct 2, 2026
owenthcarey merged commit 444637a into main Oct 2, 2026
40 checks passed
owenthcarey deleted the test/ci-stability branch October 2, 2026 06:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL