feat(cli): check for Tkinter in pn doctor - #25
Merged
owenthcarey merged 1 commit intoAug 29, 2026
Merged
owenthcarey merged 1 commit into
owenthcarey merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks for a great first contribution! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
pn preview requires Tkinter, but pn doctor previously reported a healthy environment when Tkinter was unavailable.
How
The check imports Tkinter lazily and follows the existing optional dependency result pattern. It remains a warning because mobile builds do not require the desktop preview.
Testing
Risks/Impact
Low. The new import is local to pn doctor, and missing Tkinter does not change the command exit behavior beyond the existing warning path.
Docs/Follow-ups
No documentation changes required. The warning reuses the platform install guidance already shown by pn preview.
Closes #23