FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs(mkdocs): mention pn preview in the hello-world example by TheoGoulart333 · Pull Request #50 · pythonnative/pythonnative · GitHub

docs(mkdocs): mention pn preview in the hello-world example - #50

Merged
owenthcarey merged 2 commits into
pythonnative:mainfrom
TheoGoulart333:codex/docs-hello-world-preview
Sep 2, 2026
Merged

owenthcarey merged 2 commits into
pythonnative:mainfrom
TheoGoulart333:codex/docs-hello-world-preview

Conversation

TheoGoulart333 commented Sep 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Adds a short desktop preview section to the Hello World example docs before the device/simulator instructions.

Why

Readers who land on the example page can now discover pn preview as the fastest iteration loop before using an emulator or simulator.

Validation

  • env XDG_CACHE_HOME=/Users/theo/Documents/Codex/pythonnative/.cache .venv/bin/mkdocs build --strict
  • git diff --check

Closes #42

owenthcarey changed the title docs: mention pn preview in hello world example docs(mkdocs): mention pn preview in the hello-world example Sep 2, 2026
The docs page's app/main.py snippet doesn't import emoji; only the
examples/hello-world app does. Point readers at their own
[requirements].packages instead of an install they don't need.
owenthcarey merged commit 60687a0 into pythonnative:main Sep 2, 2026
18 checks passed

Copy link
Copy Markdown
Contributor

Thanks for the fix, and for running the strict docs build before opening the PR. I pushed one small wording tweak before merging (the docs page's snippet doesn't import emoji, so the install note now points at your own [requirements].packages instead), and you're credited as the author of the squashed commit.

One request for next time: please wait for a maintainer to assign the issue before opening a PR, per the "Claiming an issue" section of CONTRIBUTING. Someone else had claimed #42 a couple of hours earlier, and the wait step is what keeps first-come claims fair. Looking forward to more from you.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hello World example docs don't mention pn preview

2 participants


Back | FazBrowse Home | New Git URL