feat(cli): add --device flag to pn logs - #67
Merged
owenthcarey merged 2 commits intoSep 3, 2026
Merged
owenthcarey merged 2 commits into
owenthcarey merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
- Add --device/-d to the logs subparser, resolving the same way pn run does via _resolve_device. - Android: set ANDROID_SERIAL from the resolved device so adb/logcat target it for the whole stream. - iOS: thread the resolved UDID into _start_ios_log_stream instead of always falling back to the booted simulator. Physical iOS devices print the existing Console.app guidance and exit, matching how pn logs already behaves without --device. - Add CLI tests covering the Android ANDROID_SERIAL path, the iOS UDID threading (both resolved and no-device/booted-fallback cases), the physical-device rejection, a bad --device query, and that --device is actually wired through argparse. - Document the new flag in docs/api/cli.md. Fixes pythonnative#38
- Print the physical-device pointer again when no simulator is booted, not only when --device names a physical device, so the pre-existing behavior of plain `pn logs ios` is unchanged. - Add a regression test for that path. - Pop ANDROID_SERIAL in the Android --device test so the value exported by the command doesn't leak into the rest of the pytest session. - Drop an unused tmp_path fixture parameter. - Mention [--device D] in the module docstring and reword the CLI reference entry without an em dash.
Copy link
Copy Markdown
Contributor
|
Thank you so much! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #38