FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs(mkdocs): cover IS_WEB in the platform-specific code FAQ by nigelseah24 · Pull Request #85 · pythonnative/pythonnative · GitHub

docs(mkdocs): cover IS_WEB in the platform-specific code FAQ - #85

Merged
owenthcarey merged 3 commits into
pythonnative:mainfrom
nigelseah24:docs/faq-docs-add-desktop-os
Sep 10, 2026
Merged

owenthcarey merged 3 commits into
pythonnative:mainfrom
nigelseah24:docs/faq-docs-add-desktop-os

Conversation

nigelseah24 commented Sep 8, 2026 •
edited by owenthcarey
Loading

Copy link
Copy Markdown
Contributor

What

Add browser preview to the FAQ's platform-specific branching example.

Why

The example only covered Android and iOS, leaving browser preview behavior
unexplained.

How

Import and branch on IS_WEB alongside IS_ANDROID and IS_IOS. Explain that
pn preview and pn start set PN_PLATFORM=web. Link to the browser preview
guide and Platform.select, including its "web" key.

Testing

  • uv run --locked --group docs mkdocs build --strict passes with this branch
    merged locally into current main.
  • Checked the rendered FAQ snippet and the browser preview guide and
    Platform.select links.

Risks/Impact

Documentation only. The FAQ still distinguishes browser preview as a
development tool and Android and iOS as app deployment targets.

Docs/Follow-ups

Updates the platform-specific code FAQ. No runtime changes are needed.

Closes #59

Copy link
Copy Markdown
Contributor

@nigelseah24, I've updated #59 for the current browser preview and kept it assigned to you. This PR is still useful with a small update:

  • Replace IS_DESKTOP with IS_WEB in the bullet, import, and branch.
  • Explain that pn preview / pn start set PN_PLATFORM=web.
  • Replace the removed ../guides/desktop-preview.md link with ../guides/browser-preview.md and use "Browser preview guide" as the label.
  • Keep the Platform.select link; browser preview uses the "web" key.
  • Update the PR title and description to refer to IS_WEB / browser preview, and run uv run --group docs mkdocs build --strict.

The original issue sent you toward APIs that #74 removed, so the stale instructions are on me. Please update this same PR; it shouldn't be merged with the desktop import or removed guide link. Thank you for catching the mismatch.

nigelseah24 force-pushed the docs/faq-docs-add-desktop-os branch from 897c1eb to 4bce863 Compare September 9, 2026 16:15
nigelseah24 force-pushed the docs/faq-docs-add-desktop-os branch from 4bce863 to 0956970 Compare September 9, 2026 16:19
nigelseah24 changed the title docs(mkdocs): cover IS_DESKTOP in the platform-specific code FAQ docs(mkdocs): cover IS_WEB in the platform-specific code FAQ Sep 9, 2026
owenthcarey merged commit 8da8fd6 into pythonnative:main Sep 10, 2026
30 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FAQ on platform-specific code omits the browser preview (IS_WEB)

2 participants


Back | FazBrowse Home | New Git URL