Repository navigation
Add Coverity Scan #390
Description
Environment
- Pythonnet version: Develop
- Python version: All
- Operating System: Windows (no Mono support)
Details
- Describe what you were trying to get done.
Add Coverity Scan to identify possible defects.
- What commands did you run to trigger this issue? If you can provide a
Minimal, Complete, and Verifiable example
this will help us understand the issue.
Here's an example from my fork. https://scan.coverity.com/projects/vmuriart-pythonnet?tab=overview
Common practice is to run Coverity Scan as a scheduled CI run against the master branch in a period basis (weekly usually). The review process can take a few hours/days so it can't be part of CI.
We would add it to Appveyor to upload on a weekly basis.
- Register Project
- Submit first build
- Add badge
- Update .gitignore for build folder
- Configure components
- Solve name clash due to double registering
- Integrate to AppVeyor as scheduled task
command to build cov-build --dir cov-int python setup.py bdist_wheel
Activity
vmuriart commented on Feb 17, 2017
Just submitted the registration application.
den-run-ai commented on Feb 17, 2017
vmuriart commented on Feb 17, 2017
Heres the project link i got
https://scan.coverity.com/projects/pythonnet-pythonnet?tab=project_settings
den-run-ai commented on Feb 17, 2017
https://scan.coverity.com/projects/pythonnet
den-run-ai commented on Feb 17, 2017
@vmuriart @tonyroberts @filmor i added you to coverity profile
vmuriart commented on Feb 17, 2017
Weird, your link gives me an error even though its now on my dashboard too and I got your invitation.
Scratch that, needed a bit of time to update on the background i guess. works now
den-run-ai commented on Feb 17, 2017
den-run-ai commented on Feb 17, 2017
@vmuriart can you unregister your pythonnet integration from coverity to github/travis ci, it complains now on mine:
vmuriart commented on Feb 17, 2017
I just deleted my project to release the link. Still getting that error. May need to email Coverity to get that resolved.
vmuriart commented on Feb 17, 2017
Just submitted a locally run version for analysis. @denfromufa would you be able to email Coverity to try solve the nameclash issue?
vmuriart commented on Feb 17, 2017
Cool, analysis finished. We could potentially bump it up to build nightly. For some reason I remember mine taking a few days from beginning to end.
den-run-ai commented on Feb 17, 2017
vmuriart commented on Feb 17, 2017
@denfromufa thats why i remembered it taking a couple days.
vmuriart commented on Feb 21, 2017
The review process is complete and the defects can be seen now.
den-run-ai commented on Feb 24, 2017
@vmuriart I also checked using VS 2015 code analysis and it shows over 300 warnings. Some of them were from recent PRs.
den-run-ai commented on Feb 24, 2017
pythonnet_VS_warnings.xlsx
vmuriart commented on Feb 24, 2017
Take some of VS's warning with a grain of salt. (https://www.slideshare.net/Coverity/finding-defects-in-c-01-2014)
Looks like CA1060 can be filtered out though. A couple other issues in that list I've commented in the code already. The list actually looks like its missing more warnings though, there should be a few about variables being declared and not used.