Repository navigation
#1047 ModuleObject __getattribute__ doesn't treat exceptions ocurred during internal GetAttribute - #1048
Merged
lostmsu merged 3 commits intoFeb 22, 2020
Merged
#1047 ModuleObject __getattribute__ doesn't treat exceptions ocurred during internal GetAttribute#1048lostmsu merged 3 commits into
lostmsu merged 3 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
added 2 commits
February 20, 2020 12:03
… ocurred during internal GetAttribute
… ocurred during internal GetAttribute
lostmsu
reviewed
Feb 20, 2020
Comment thread
src/runtime/moduleobject.cs
| } | ||
|
|
||
| ManagedType attr = self.GetAttribute(name, true); | ||
| ManagedType attr = null; |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
NIT: = null is not needed AFAIK
Sorry, something went wrong.
lostmsu
approved these changes
Feb 20, 2020
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #1048 +/- ##
=======================================
Coverage 86.75% 86.75%
=======================================
Files 1 1
Lines 302 302
=======================================
Hits 262 262
Misses 40 40
Continue to review full report at Codecov.
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…during internal GetAttribute
What does this implement/fix? Explain your changes.
It converts any exception retured from GetAttribute into a Python exception
Does this close any currently open issues?
Yes, Issue #1047
Checklist
Check all those that are applicable and complete.