Repository navigation
Fixed TupleCodec not clearing Python exception after unsuccessful decoding - #1083
Merged
filmor merged 1 commit intoMar 10, 2020
Merged
filmor merged 1 commit into
filmor merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…ement decoding attempt
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #1083 +/- ##
=======================================
Coverage 86.75% 86.75%
=======================================
Files 1 1
Lines 302 302
=======================================
Hits 262 262
Misses 40 40
Continue to review full report at Codecov.
|
Sorry, something went wrong.
AlexCatarino
pushed a commit
to QuantConnect/pythonnet
that referenced
this pull request
Jun 29, 2020
…ement decoding attempt (pythonnet#1083)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
When TupleCodec.TryDecode is trying to decode a tuple from Python to .NET, and the element type in Python does not match one in .NET, Converter.ToManaged on that element will fail and leave PyErr set. That caused it to be picked up later by a random check for PyErr and raised as .NET exception in unexpected places.
This change clears PyErr in TryDecode if decoding of an element fails, thus allowing other codecs/overloads to be probed safely.