FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Params arg no params by slide · Pull Request #1106 · pythonnet/pythonnet · GitHub

/ pythonnet Public

Params arg no params - #1106

Merged
filmor merged 12 commits into
pythonnet:masterfrom
slide:params_arg_no_params
May 16, 2020
ConversationCommits (12)ChecksFiles changed
Merged

Params arg no params#1106
filmor merged 12 commits into
pythonnet:masterfrom
slide:params_arg_no_params

Conversation

slide commented Apr 8, 2020

Copy link
Copy Markdown
Contributor

What does this implement/fix? Explain your changes.

Check the last parameter to see if it is params (and not supplied). By setting the paramsArray variable, the binding code does the right thing and passes an empty array.

Does this close any currently open issues?

#943

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Add yourself to AUTHORS
  • Updated the CHANGELOG

slide added 3 commits April 7, 2020 14:42
Add check for ParamArrayAttribute
6beaf82
Fix #943
0392fdc 
Add a check to see if the last parameter is a params parameter. Set the correct flag to show that it is a paramsArray function.
Add CHANGELOG entry
5a76273

codecov-io commented Apr 8, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1106 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1106   +/-   ##
=======================================
  Coverage   86.75%   86.75%           
=======================================
  Files           1        1           
  Lines         302      302           
=======================================
  Hits          262      262           
  Misses         40       40
Flag Coverage Δ
#setup_linux 65.56% <ø> (ø)
#setup_windows 71.52% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 638dc1c...5a76273. Read the comment docs.

lostmsu requested changes Apr 9, 2020
View reviewed changes
Comment thread src/runtime/methodbinder.cs Outdated
Comment thread src/runtime/methodbinder.cs Outdated

slide commented Apr 9, 2020

Copy link
Copy Markdown
Contributor Author

Close and reopen to see if the build is intermittent.

slide closed this Apr 9, 2020
lostmsu reopened this Apr 9, 2020
lostmsu reviewed Apr 9, 2020
View reviewed changes
Comment thread src/runtime/methodbinder.cs Outdated

slide commented Apr 9, 2020

Copy link
Copy Markdown
Contributor Author

Thanks for reopening, got pulled into a meeting and didn't get a chance to reopen.

lostmsu commented Apr 9, 2020

Copy link
Copy Markdown
Member

@slide better this one. Then I can squash.

lostmsu approved these changes Apr 9, 2020
View reviewed changes
Comment thread src/runtime/methodbinder.cs Outdated

lostmsu commented Apr 9, 2020

Copy link
Copy Markdown
Member

@slide Travis passed. Need to investigate why is it not being picked up.

lostmsu mentioned this pull request Apr 9, 2020
Closed

dnfclas commented Apr 9, 2020 •
edited
Loading

Copy link
Copy Markdown


All CLA requirements met.

slide commented Apr 16, 2020

Copy link
Copy Markdown
Contributor Author

Close and reopen to try and get a Travis build responding.

slide closed this Apr 16, 2020
slide reopened this Apr 16, 2020
filmor merged commit 49a230b into pythonnet:master May 16, 2020

filmor commented May 16, 2020

Copy link
Copy Markdown
Member

Thank you very much :)

AlexCatarino pushed a commit to QuantConnect/pythonnet that referenced this pull request Jun 29, 2020
Fix params argument handling (pythonnet#1106)
c8586bb 
Add a check to see if the last parameter is a params parameter. Set the correct flag to show that it is a paramsArray function.

Fixes pythonnet#943 and pythonnet#331.
filmor mentioned this pull request Jul 21, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lostmsu lostmsu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL