FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Modernization stage1 by koubaa · Pull Request #1117 · pythonnet/pythonnet · GitHub

/ pythonnet Public

Modernization stage1 - #1117

Closed
koubaa wants to merge 5 commits into
pythonnet:masterfrom
koubaa:modernization-stage1
ConversationCommits (5)ChecksFiles changed
Closed

Modernization stage1#1117
koubaa wants to merge 5 commits into
pythonnet:masterfrom
koubaa:modernization-stage1

Conversation

koubaa commented Apr 17, 2020

Copy link
Copy Markdown
Contributor

What does this implement/fix? Explain your changes.

pulls out a first stage from this PR:
https://github.com/pythonnet/pythonnet/pull/1109/files
...

Does this close any currently open issues?

no
...

Any other comments?

...

Checklist

Check all those that are applicable and complete.

  • [N/A] Make sure to include one or more tests for your change
  • [N/A] If an enhancement PR, please create docs and at best an example
  • Add yourself to AUTHORS
  • Updated the CHANGELOG

filmor and others added 4 commits April 16, 2020 21:16
Drop PYTHON3 flag (default now)
3b88515
Stop using Runtime.IsPython2/3
7d6c4ac 
Contrary to what I said before, I don't think trying to provide
a single DLL for Python 2 and 3. We will in the future default
to Python 3, and if someone really wants Python 2, for a while
we will support a separate compile configuration for that.
drop remoting
14230b0
update changelog
32d4f0a

koubaa commented Apr 17, 2020

Copy link
Copy Markdown
Contributor Author

@filmor this is the first stage I described (although I couldn't figure out what you mean by custom IncRef and DecRef)

koubaa mentioned this pull request Apr 17, 2020
Closed
4 tasks
filmor reviewed Apr 17, 2020
View reviewed changes
Comment thread src/runtime/runtime.cs Outdated
lostmsu requested changes Apr 21, 2020
View reviewed changes

lostmsu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Seems fine to me, but must fix CI.

lostmsu commented May 1, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

@filmor if this is targeting Python.NET 3+, I think we should just drop Python 2 support altogether with all related code.

Keeping those #ifs, but not making newly added code Python 2 compatible, and not running CI tests won't help people trying to backport, and will only get in our way.

We can just remove all Python 2-related code in a single commit, including the CI checks. Whoever needs it then can just revert it and try to work from there (which I doubt will ever happen).

@koubaa @filmor in my branch I simply use a static check using RuntimeInformation.IsOSPlatform to decide between UCS2 and UCS4, then just cache boolean flag. I don't think it has any significant impact on performance as opposed to using #ifs.

koubaa commented May 1, 2020

Copy link
Copy Markdown
Contributor Author

@lostmsu @filmor this changeset is targeting the 2.x branch. I totally agree with dropping python2 support in the 3.x branch.

koubaa closed this Jun 23, 2020
koubaa deleted the modernization-stage1 branch June 23, 2020 14:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

filmor filmor left review comments
lostmsu lostmsu requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL