Codecov Report

Merging #1118 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1118   +/-   ##
=======================================
  Coverage   86.75%   86.75%           
=======================================
  Files           1        1           
  Lines         302      302           
=======================================
  Hits          262      262           
  Misses         40       40           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a83fe5...007e5dd. Read the comment docs.

Hmm, I think in general this is fine because we don't lose anything (As<PyObject> will still work), but it's nevertheless a silent breaking change. This is possible in the future, but I wouldn't want to do it during a point-release. Can you introduce a preliminary new function for this behaviour?

@filmor I can do that. I will also create a new issue to address this in a major release.

@koubaa if this is specifically targeted to conversion to object, why does it have to be generic?

@koubaa if this is specifically targeted to conversion to object, why does it have to be generic?

@lostmsu good point. It would be more clear to just call it AsObject

@koubaa there is already AsManagedObject(Type). Does it not work for you? It appears to be doing the same when Type == object.

@lostmsu didn't know about that. I don't need this change anymore