Repository navigation
Removes new object.GetRawPythonProxy extension method - #1132
Merged
filmor merged 1 commit intoMay 1, 2020
Merged
filmor merged 1 commit into
filmor merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…sting PyObject.FromManagedObject Reverts most of pythonnet#1078
AlexCatarino
pushed a commit
to QuantConnect/pythonnet
that referenced
this pull request
Jun 29, 2020
…sting PyObject.FromManagedObject (pythonnet#1132) Reverts most of pythonnet#1078
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Reverts most of #1078
Turned out there already was PyObject.FromManagedObject. It was not covered by tests however, so I changed former GetRawPythonProxy tests to test FromManagedObject
Does this close any currently open issues?
No
Checklist
Check all those that are applicable and complete.